Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updating SIP issue template to boost the link, and (hopefully) reduce duplicate-numbered SIP issues. #21896

Merged
merged 1 commit into from
Oct 21, 2022
Merged

chore: Updating SIP issue template to boost the link, and (hopefully) reduce duplicate-numbered SIP issues. #21896

merged 1 commit into from
Oct 21, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

This PR does a few things:

  1. Moves the link to SIP-0 to the template list page (not sure if this will work!)
  2. Removes instructions for people to number their own sip. A committer should do this, per SIP-0
  3. Adjusts the PR title accordingly to item 2.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Open a new issue when merged, make sure the link works!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #21896 (bc081e2) into master (52d33b0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21896      +/-   ##
==========================================
+ Coverage   66.90%   66.91%   +0.01%     
==========================================
  Files        1805     1805              
  Lines       69073    69064       -9     
  Branches     7369     7369              
==========================================
+ Hits        46214    46217       +3     
+ Misses      20952    20933      -19     
- Partials     1907     1914       +7
Flag Coverage Δ
hive 52.92% <ø> (ø)
javascript 53.31% <ø> (+0.02%) ⬆️
mysql 78.35% <ø> (ø)
postgres 78.41% <ø> (ø)
presto 52.82% <ø> (ø)
python 81.47% <ø> (ø)
sqlite 76.90% <ø> (ø)
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/actions/dashboardInfo.ts 50.00% <0.00%> (-11.54%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 53.57% <0.00%> (-1.48%) ⬇️
...-frontend/src/dashboard/reducers/dashboardState.js 76.08% <0.00%> (-0.51%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 59.85% <0.00%> (-0.45%) ⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx 7.14% <0.00%> (-0.12%) ⬇️
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/index.ts 100.00% <0.00%> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 66.66% <0.00%> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx 85.00% <0.00%> (ø)
...uperset-ui-core/src/color/CategoricalColorScale.ts 100.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

betodealmeida
betodealmeida approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this through a SIP? #meta

geido
geido approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! On a side note, I have been re-running some failing Cypress tests for this PR. We should probably dedicate some time to fix as many flaky tests as possible. Most of the failing tests appear on CI not locally. It requires a bit of investigation work.

@rusackas rusackas merged commit 04b017e into master Oct 21, 2022
@rusackas rusackas deleted the sip-template-tweaks branch October 21, 2022 13:57
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusackas @betodealmeida @geido @mistercrunch